Skip to content

Conversation

@matthewbastien
Copy link
Member

Reverts #2039

Our nightly CI is failing on the Test Explorer Suite.

@matthewbastien matthewbastien added the full-test-run Perform a full test suite run. Apply this label before pushing up a PR or commit label Jan 28, 2026
@matthewbastien matthewbastien merged commit f2eb5de into main Jan 28, 2026
23 checks passed
@matthewbastien matthewbastien deleted the revert-2039-no-more-wait-for-parameterized-tests branch January 28, 2026 19:52
plemarquand added a commit to plemarquand/vscode-swift that referenced this pull request Feb 3, 2026
Un-reverts f2eb5de (swiftlang#2060), which
marked tests runs as started for both XCTest and swift-testing
immediately, but only when not debugging. This version marks tests as
started immediately both when debugging and when running without the
debugger. Original commit message follows.

Previously we were waiting for all parameterized test items to be
emitted on the JSON event stream before starting the `vscode.TestRun`.

This limitation was in place to ensure we had all the test items in test
request sent to VSCode, as we couldn't add test items after a run had
started.

That requirement seems to have been relaxed, or we were just not
refreshing the test explorer correctly after dynamically adding items,
but regardless it looks like we can dynamically add items now.

This means we can correctly mark a test run as "started" immediately
when the user starts compiling a test like we do with XCTest, making the
two testing libraries the same in this regard. It also simplifies the
code, allowing us to accept and inject new parameterized test items at
any time during a run.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

full-test-run Perform a full test suite run. Apply this label before pushing up a PR or commit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants